Skip to content

Instantly share code, notes, and snippets.

@EionRobb
Created May 20, 2020 20:56
Show Gist options
  • Save EionRobb/9404e2aa7722074c1549595556bd4c63 to your computer and use it in GitHub Desktop.
Save EionRobb/9404e2aa7722074c1549595556bd4c63 to your computer and use it in GitHub Desktop.
pvs-studio output tdlib-purple 2020-05-21
Unable to create an event source, error logging to system events will be disabled. To enable event logging, please run this application under elevated privileges at least once. 0
V659 Declarations of functions with 'map' name differ in the 'const' keyword only, but the bodies of these functions have different composition. This is suspicious and can possibly be an error. Check lines: 1022, 1030. core.h 1030
V659 Declarations of functions with 'map' name differ in the 'const' keyword only, but the bodies of these functions have different composition. This is suspicious and can possibly be an error. Check lines: 1026, 1034. core.h 1034
V530 The return value of function 'release' is required to be utilized. core.h 1502
V1051 Consider checking for misprints. It's possible that the 'num_zeros' should be checked here. format.h 1115
V783 Dereferencing of the invalid iterator 'it ++' might take place. format.h 1668
V821 Decreased performance. The 'specs' variable can be constructed in a lower level scope. format.h 1841
V690 The 'specs_setter' class implements a copy constructor, but lacks the copy assignment operator. It is dangerous to use such a class. format.h 1994
V690 The 'specs_checker' class implements a copy constructor, but lacks the copy assignment operator. It is dangerous to use such a class. format.h 2060
V690 The 'dynamic_specs_handler' class implements a copy constructor, but lacks the copy assignment operator. It is dangerous to use such a class. format.h 2209
V556 The values of different enum types are compared: align != align::none. Types: type, type. format.h 2359
V1037 Two or more case-branches perform the same actions. Check lines: 2939, 2945, 2951 format.h 2939
V813 Decreased performance. The 'args' argument should probably be rendered as a constant reference. os.h 251
V547 Expression 'count <= (0x7fffffff * 2U + 1U)' is always true. os.cc 63
V813 Decreased performance. The 'args' argument should probably be rendered as a constant reference. os.cc 105
V565 An empty exception handler. Silent suppression of exceptions can hide the presence of bugs in source code during testing. os.cc 137
V634 The priority of the '*' operation is higher than that of the '<<' operation. It's possible that parentheses should be used in the expression. os.cc 218
V730 It is possible that not all members of a class are initialized inside the constructor. Consider inspecting: buffer_. format.h 2867
V730 It is possible that not all members of a class are initialized inside the constructor. Consider inspecting: buffer_. format.h 2868
V730 It is possible that not all members of a class are initialized inside the constructor. Consider inspecting: buffer_. format.h 2869
V730 Not all members of a class are initialized inside the constructor. Consider inspecting: buffer_. format.h 2870
V730 Not all members of a class are initialized inside the constructor. Consider inspecting: buffer_. format.h 2871
V730 Not all members of a class are initialized inside the constructor. Consider inspecting: buffer_. format.h 2872
V690 The copy assignment operator is declared as private in the 'dispatcher' class, but the default copy constructor will still be generated by compiler. It is dangerous to use such a class. format-inl.h 82
V813 Decreased performance. The 'args' argument should probably be rendered as a constant reference. format-inl.h 221
V813 Decreased performance. The 'x', 'y' arguments should probably be rendered as constant references. format-inl.h 447
V813 Decreased performance. The 'x', 'y' arguments should probably be rendered as constant references. format-inl.h 467
V669 The 'exp' argument is a non-constant reference. The analyzer is unable to determine the position at which this argument is being modified. It is possible that the function contains an error. format-inl.h 879
V507 Pointer to local array 'buf' is stored outside the scope of this array. Such a pointer will become invalid. format-inl.h 1328
V565 An empty exception handler. Silent suppression of exceptions can hide the presence of bugs in source code during testing. format-inl.h 1354
V813 Decreased performance. The 'args' argument should probably be rendered as a constant reference. format-inl.h 1390
V813 Decreased performance. The 'args' argument should probably be rendered as a constant reference. format-inl.h 1398
V553 The length of 'downcast_call' function's body is more than 2000 lines long. You should consider refactoring the code. td_api.hpp 20
V576 Incorrect format. Consider checking the fifth actual argument of the 'purple_debug_misc' function. The UNSIGNED integer type argument is expected. td-client.cpp 521
V576 Incorrect format. Consider checking the third actual argument of the 'purple_debug_warning' function. The UNSIGNED integer type argument is expected. td-client.cpp 1136
V576 Incorrect format. Consider checking the third actual argument of the 'purple_debug_misc' function. The UNSIGNED integer type argument is expected. td-client.cpp 1143
V576 Incorrect format. Consider checking the third actual argument of the 'purple_debug_warning' function. The UNSIGNED integer type argument is expected. td-client.cpp 1149
V618 It's dangerous to call the 'purple_debug_warning' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str); td-client.cpp 1309
V1040 Possible typo in the spelling of a pre-defined macro name. The '__MINGW_H' macro is similar to '__MINGW__'. gutils.h 299
V807 Decreased performance. Consider creating a reference to avoid using the 'self->m_rxQueue' expression repeatedly. transceiver.cpp 148
V807 Decreased performance. Consider creating a reference to avoid using the 'self->m_responseHandlers' expression repeatedly. transceiver.cpp 164
V526 The 'strncmp' function returns 0 if corresponding strings are equal. Consider examining the condition for mistakes. account-data.cpp 34
V773 Visibility scope of the '__p' pointer was exited without releasing the memory. A memory leak is possible. chat-info.cpp 13
V773 Visibility scope of the '__p' pointer was exited without releasing the memory. A memory leak is possible. chat-info.cpp 19
V773 Visibility scope of the '__p' pointer was exited without releasing the memory. A memory leak is possible. chat-info.cpp 25
V799 The '__p' variable is not used after memory has been allocated for it. Consider checking the use of this variable. chat-info.cpp 13
V799 The '__p' variable is not used after memory has been allocated for it. Consider checking the use of this variable. chat-info.cpp 19
V799 The '__p' variable is not used after memory has been allocated for it. Consider checking the use of this variable. chat-info.cpp 25
V821 Decreased performance. The 'chatName' variable can be constructed in a lower level scope. client-utils.cpp 141
V815 Decreased performance. Consider replacing the expression 'text = ""' with 'text.clear()'. client-utils.cpp 297
V560 A part of conditional expression is always true: (imageId <= 2147483647). client-utils.cpp 551
V560 A part of conditional expression is always true: (imageId >= (- 2147483647 - 1)). client-utils.cpp 552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment