Skip to content

Instantly share code, notes, and snippets.

@davidfischer

davidfischer/datdota-filters.diff

Created March 9, 2018 22:54
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save davidfischer/3c5d679fe106a1d0d13d84c49221384a to your computer and use it in GitHub Desktop.
Save davidfischer/3c5d679fe106a1d0d13d84c49221384a to your computer and use it in GitHub Desktop.
Download ZIP
DatDota match filters improvements
Raw
datdota-filters.diff
diff --git a/datdota.com/heroes/elo.html b/datdota.com/heroes/elo.html
index 39b37d2..8518f93 100644
--- a/datdota.com/heroes/elo.html
+++ b/datdota.com/heroes/elo.html
@@ -316,7 +316,7 @@ Help!
<hr>
<div class="ibox float-e-margins">
<form method="get" class="form-horizontal">
-<div class="col-md-4">
+<div class="col-lg-6 col-md-12">
<h3>Team Filters</h3>
<div class="col-md-12">
<div class="form-group">
@@ -519,7 +519,7 @@ Help!
});
</script>
</div>
-<div class="col-md-4">
+<div class="col-lg-6 col-md-12">
<h3>Match Filters</h3>
<div class="col-md-12">
<div class="col-md-6">
@davidfischer
Copy link
Author

Minimum 1200px wide
When the viewport is at least 1200px wide, the two filters split the container 50/50 (rather than 33% as before). This yields a little better results up to ~1920px wide after which I'd say a col-XX-4 looks a little better. However, I think this is an improvement overall.
screen shot 2018-03-09 at 2 52 49 pm

Less than 1200px wide
At less than 1200px wide, it stacks the two filters.
screen shot 2018-03-09 at 2 53 04 pm

@Noxville
Copy link

Noxville commented Mar 10, 2018 •
edited

Do you have any proposals for 3-column layouts? For example - the crits page (http://datdota.com/crits?default=true)

Otherwise, updated:

    modified:   grails-app/controllers/disdota/RestEventController.groovy
    modified:   grails-app/controllers/disdota/TeamsController.groovy
    modified:   grails-app/views/caster/index.gsp
    modified:   grails-app/views/hero/elo.gsp
    modified:   grails-app/views/hero/eloHeadToHead.gsp
    modified:   grails-app/views/hero/frequentPlayers.gsp
    modified:   grails-app/views/lanes/compositions.gsp
    modified:   grails-app/views/matches/lengthDistribution.gsp
    modified:   grails-app/views/players/squads.gsp
    modified:   grails-app/views/ratings/index.gsp
    modified:   grails-app/views/ratings/top.gsp
    modified:   grails-app/views/teams/headToHead.gsp
    modified:   grails-app/views/teams/performances.gsp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment