Skip to content

Instantly share code, notes, and snippets.

@bhrutledge

bhrutledge/code-review.md

Last active July 30, 2019 14:06
Show Gist options
  • Star 1 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save bhrutledge/a564a90ac117ea5c30e83255dc9a8ffa to your computer and use it in GitHub Desktop.
Save bhrutledge/a564a90ac117ea5c30e83255dc9a8ffa to your computer and use it in GitHub Desktop.
Download ZIP
Talks on how to do better code reviews
Raw
code-review.md

Code Review

Talks on how to do them better.

Code Reviews Using Art Critique Principles

Code Review Skills for Pythonistas

  • Nina Zakharenko, DjangoCon US 2018
  • Slides

How to Do Code Reviews Like a Human

  • Michael Lynch, PyGotham 2018
  • Slides
  • Finding bugs is only one purpose of many
  • Bonding/learning opportunity for teammates
  • Use style guide, enforced by linters, formatters, and CI
  • Offer code examples as help, not gatekeeping
  • Avoid "you"; prefer "we", "what about", passive voice
  • Give feedback via requests, not commmands

Code Review, Forwards and Back

  • A series of short plays from PyGotham 2017
  • "We have pretty code, but it does dumb things"
  • Easy to get blocked on hypothetical architecture changes
  • Poor communication and knowledge sharing seems to be the root problem
  • Do initial reviews in person
  • Teach best practices via pair programming
  • Smaller commits w/ good messages are easier to review
  • Use linters to catch style errors
@skybondsor
Copy link

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment