gregdevs · December 5, 2019 14:08
diff --git a/Refactored NBC thoughts b/Refactored NBC thoughts
 //******REFACTORED CODE*****///

 Going off ofmy memory of the test but I wanted to point out some improvements I would have made 
 // Instead of iterating and attaching event listeners on each path element, I would've wanted to go back and just have the click event attached to the parent and grab the target elem path from that instead. 

 const svgelem = document.querySelector('svg');

 svgelem.addEventListener('click', function(e){
     const state = e.target.getAttribute('data-state'),  
           votes = e.target.getAttribute('data-votes'),
           party = e.target.getAttribute('data-party')
   handleVotes(state, votes, party)
  // remove if/else block here
 })

 // Also, my if/else block with the vote count and class logic could  be turned into a function passing in some params

 //something like

 function handleVotes(state, votes, party) {
       do logic here
 }
	//****REFACTORED CODE***///

	Going off ofmy memory of the test but I wanted to point out some improvements I would have made
	// Instead of iterating and attaching event listeners on each path element, I would've wanted to go back and just have the click event attached to the parent and grab the target elem path from that instead.

	const svgelem = document.querySelector('svg');

	svgelem.addEventListener('click', function(e){
	const state = e.target.getAttribute('data-state'),
	votes = e.target.getAttribute('data-votes'),
	party = e.target.getAttribute('data-party')
	handleVotes(state, votes, party)
	// remove if/else block here
	})

	// Also, my if/else block with the vote count and class logic could be turned into a function passing in some params

	//something like

	function handleVotes(state, votes, party) {
	do logic here
	}